Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor unexported pack methods #573

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

Wwwsylvia
Copy link
Member

I'm splitting PR #572 into 2 parts, this is the first part.

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #573 (195450b) into main (e6d40b6) will increase coverage by 0.08%.
The diff coverage is 92.68%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #573      +/-   ##
==========================================
+ Coverage   74.15%   74.24%   +0.08%     
==========================================
  Files          51       51              
  Lines        4787     4814      +27     
==========================================
+ Hits         3550     3574      +24     
- Misses        908      910       +2     
- Partials      329      330       +1     
Files Changed Coverage Δ
pack.go 83.68% <92.68%> (+0.86%) ⬆️

pack.go Outdated Show resolved Hide resolved
pack.go Show resolved Hide resolved
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 60da91b into oras-project:main Aug 24, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the pack_refactor branch August 24, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants