Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate input media type for oras.PackManifest #574

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

Wwwsylvia
Copy link
Member

Resolves: #571

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
pack.go Outdated Show resolved Hide resolved
pack.go Outdated Show resolved Hide resolved
pack.go Outdated Show resolved Hide resolved
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Merging #574 (d6a34ac) into main (60da91b) will decrease coverage by 0.03%.
The diff coverage is 76.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
- Coverage   74.24%   74.21%   -0.03%     
==========================================
  Files          51       51              
  Lines        4814     4832      +18     
==========================================
+ Hits         3574     3586      +12     
- Misses        910      914       +4     
- Partials      330      332       +2     
Files Changed Coverage Δ
pack.go 82.21% <76.19%> (-1.48%) ⬇️

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 47d028a into oras-project:main Aug 24, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the pack_validate branch August 24, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should validate input artifactType and config mediaType for oras.PackManifest
3 participants