Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mod to oras.land/oras-go/v2 #77

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Update go.mod to oras.land/oras-go/v2 #77

merged 1 commit into from
Nov 23, 2021

Conversation

shizhMSFT
Copy link
Contributor

Resolves #76

@shizhMSFT
bump up to v2
47222b3 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@deitch
Copy link
Contributor

deitch commented Nov 21, 2021

Is this not going to cause issues elsewhere on pkg/, where it still includes the non-v2 path?

@shizhMSFT
Copy link
Contributor Author

The pkg folder will not be impacted. Before we releasing 2.0, we will do #63 and eventually remove the entire /pkg folder.

All old implementation will still be there in the v1 branch and tagged by v1.x.x. Developers can import oras.land/oras-go v1.0.0 to access oras.land/oras-go/pkg.

SteveLasker
SteveLasker approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 8b6a763 into oras-project:main Nov 23, 2021
@shizhMSFT shizhMSFT deleted the bump_v2 branch November 23, 2021 07:29
@shizhMSFT shizhMSFT mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@SteveLasker SteveLasker SteveLasker approved these changes

@deitch deitch Awaiting requested review from deitch

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update go.mod in main to oras.land/oras-go/v2
4 participants
@shizhMSFT @deitch @jdolitsky @SteveLasker