Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Target #80

Merged
merged 3 commits into from
Dec 24, 2021
Merged

Memory Target #80

merged 3 commits into from
Dec 24, 2021

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT added this to Backlog in ORAS CLI/Go-lib Project Board via automation Dec 2, 2021
@shizhMSFT shizhMSFT changed the title Memory target Memory Target Dec 2, 2021
Wwwsylvia
Wwwsylvia reviewed Dec 2, 2021
View reviewed changes
content/memory/memory.go Outdated Show resolved Hide resolved
Wwwsylvia
Wwwsylvia approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajayantony
Copy link
Contributor

I believe this addreses @deitch's earlier questions. Would be good to have an LGTM from @deitch

@shizhMSFT
memory target
63d25b1 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
copy test
666f823 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
reduce name confusion
1d8e0a3 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
deitch
deitch approved these changes Dec 24, 2021
View reviewed changes
Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I compared it to what we have, I think I rather like how this is structured. I spent some time on the internal structure, but mostly seeing functionality via the good tests.

@deitch
Copy link
Contributor

deitch commented Dec 24, 2021

I was going to merge this in, but don't know if you are ready for it @shizhMSFT .

@shizhMSFT
Copy link
Contributor Author

@deitch I'm ready to merge it.

@deitch deitch merged commit ec31af0 into oras-project:main Dec 24, 2021
ORAS CLI/Go-lib Project Board automation moved this from Backlog to Done Dec 24, 2021
@shizhMSFT shizhMSFT deleted the memory_target branch December 24, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deitch deitch deitch approved these changes

@Wwwsylvia Wwwsylvia Wwwsylvia approved these changes

@jdolitsky jdolitsky Awaiting requested review from jdolitsky

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
ORAS CLI/Go-lib Project Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Target
4 participants
@shizhMSFT @sajayantony @deitch @Wwwsylvia