Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of tag listing to v1 #89

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

sabre1041
Copy link
Contributor

Backport of v2 registry tag listing to support Helm as outlined in HIP-6

Also includes changes proposed in #88

CC: @scottrigby @deitch @jdolitsky @scottrigby @SteveLasker

Signed-off-by: Andrew Block <andy.block@gmail.com>
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears relatively safe and tests passing

Copy link
Contributor

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am impressed it went in so cleanly. Thanks for getting this done @sabre1041 , and I should say hats off to @shizhMSFT for doing his implementation in a way that made it straightforward.

@deitch deitch merged commit 7487cd1 into oras-project:v1 Jan 7, 2022
scottrigby added a commit to scottrigby/helm that referenced this pull request Jan 7, 2022
Now that oras-project/oras-go#89 is merged and released

Signed-off-by: Scott Rigby <scott@r6by.com>
@scottrigby
Copy link
Contributor

Would a maintainer mind please renaming this PR to remove the "WIP" (since it is no longer a work in progress). Thanks ❤️

@deitch deitch changed the title WIP: Backport of tag listing to v1 Backport of tag listing to v1 Jan 11, 2022
scottrigby added a commit to scottrigby/helm that referenced this pull request Jan 12, 2022
Now that oras-project/oras-go#89 is merged and released

Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby added a commit to scottrigby/helm that referenced this pull request Jan 12, 2022
Now that oras-project/oras-go#89 is merged and released

Signed-off-by: Scott Rigby <scott@r6by.com>
zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
Now that oras-project/oras-go#89 is merged and released

Signed-off-by: Scott Rigby <scott@r6by.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants