Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fallback on Docker config using custom auth file #92

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Enable fallback on Docker config using custom auth file #92

merged 1 commit into from
Jan 11, 2022

Conversation

jdolitsky
Copy link
Contributor

@scottrigby scottrigby mentioned this pull request Jan 11, 2022
Closed
6 tasks
@sajayantony
Copy link
Contributor

@jdolitsky @Wwwsylvia should this be in backported to main or has main removed need for docker-cli and it way more complicated now?

@jdolitsky
Enable fallback on Docker config using custom auth file
5fc4e56 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@jdolitsky
Copy link
Contributor Author

The difference between NewClient and NewClientWithDockerFallback is subtle - NewClient will only use Docker's config if no config paths provided, whereas NewClientWithDockerFallback will use Docker's config always.

@jdolitsky jdolitsky merged commit f487ae5 into oras-project:v1 Jan 11, 2022
zonggen pushed a commit to zonggen/helm that referenced this pull request Jan 11, 2022
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
9b50df9 
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.

Ref:
 - helm#10536 (comment)
 - oras-project/oras-go#92
Signed-off-by: Allen Bai <abai@redhat.com>
zonggen pushed a commit to zonggen/helm that referenced this pull request Jan 11, 2022
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
f706a11 
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.

Ref:
 - helm#10536 (comment)
 - oras-project/oras-go#92
Signed-off-by: Allen Bai <abai@redhat.com>
zonggen pushed a commit to zonggen/helm that referenced this pull request Jan 11, 2022
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
e3897ad 
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.

Ref:
 - helm#10536 (comment)
 - oras-project/oras-go#92
Signed-off-by: Allen Bai <abai@redhat.com>
@shizhMSFT
Copy link
Contributor

should this be in backported to main or has main removed need for docker-cli and it way more complicated now?

This should not be backported to main as main will remove pkg/ eventually.

zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
@zak905
registry/client: use NewClientWithDockerFallback from oras v1.1.0-rc3
cd2a39c 
Uses NewClientWithDockerFallback to always use Docker config and
modifies go.mod to use oras v1.1.0-rc3.

Ref:
 - helm#10536 (comment)
 - oras-project/oras-go#92
Signed-off-by: Allen Bai <abai@redhat.com>
@moshe-kabala moshe-kabala mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 left review comments

@sajayantony sajayantony sajayantony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdolitsky @sajayantony @shizhMSFT @sabre1041