Apply appropriate header for authentication against a gitlab registry #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You beat me to it! so the oras projects requires signed commits, if you are able to do that. The other tweak is to bump the version in oras/version.py and add a note to the CHANGELOG. |
magelisk
force-pushed
the
49-fix-gitlab-registry-auth
branch
2 times, most recently
from
10db8d8
to
35906eb
Compare
Signed-off-by: Matt Warner <18201513+magelisk@users.noreply.github.com>
magelisk
force-pushed
the
49-fix-gitlab-registry-auth
branch
from
35906eb
to
615bd32
Compare
|
I believe I got it all worked out. Signed and version+CHANGELOG updated |
vsoch
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a fix to set the
service=container_registryto the request params rather than just headers. This is needed for gitlab registry authentication.This is a simple fix for #49 , I don't know for certain if this may have negative impact for not gitlab registries.