New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: redirects issue #146
fix: redirects issue #146
Conversation
Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://deploy-preview-146--oras-project.netlify.app/oras gives 404 not found
without any <meta>
and thus cannot be recognised by go
.
Strange, since those 3 files contain |
@asmitbm You may run the following script to verify. /cc @FeynmanZhou pr=146
for module in oras oras-go oras-go/v2; do
echo "> $module: checking"
curl -s "https://deploy-preview-$pr--oras-project.netlify.app/$module" |
grep -e go-import -e go-source &&
echo "< $module: verified" ||
echo "< $module: failed"
done Here's a sample output of a successful run: $ pr=139
$ for module in oras oras-go oras-go/v2; do
echo "> $module: checking"
curl -s "https://deploy-preview-$pr--oras-project.netlify.app/$module" |
grep -e go-import -e go-source &&
echo "< $module: verified" ||
echo "< $module: failed"
done
> oras: checking
<meta name=go-import content="oras.land/oras git https://github.com/oras-project/oras"><meta name=go-source content="oras.land/oras git https://github.com/oras-project/oras https://github.com/oras-project/oras/tree/main{/dir} https://github.com/oras-project/oras/blob/main{/dir}/{file}#L{line}"><meta http-equiv=refresh content="0; url=https://github.com/oras-project/oras">
< oras: verified
> oras-go: checking
<meta charset=utf-8><meta name=go-import content="oras.land/oras-go git https://github.com/oras-project/oras-go"><meta name=go-source content="oras.land/oras-go git https://github.com/oras-project/oras-go https://github.com/oras-project/oras-go/tree/main{/dir} https://github.com/oras-project/oras-go/blob/main{/dir}/{file}#L{line}"><meta http-equiv=refresh content="0; url=https://github.com/oras-project/oras-go">
< oras-go: verified
> oras-go/v2: checking
<meta charset=utf-8><meta name=go-import content="oras.land/oras-go/v2 git https://github.com/oras-project/oras-go"><meta name=go-source content="oras.land/oras-go/v2 git https://github.com/oras-project/oras-go https://github.com/oras-project/oras-go/tree/main{/dir} https://github.com/oras-project/oras-go/blob/main{/dir}/{file}#L{line}"><meta http-equiv=refresh content="0; url=https://github.com/oras-project/oras-go">
< oras-go/v2: verified and also a failed run: $ pr=146
$ for module in oras oras-go oras-go/v2; do
echo "> $module: checking"
curl -s "https://deploy-preview-$pr--oras-project.netlify.app/$module" |
grep -e go-import -e go-source &&
echo "< $module: verified" ||
echo "< $module: failed"
done
> oras: checking
< oras: failed
> oras-go: checking
< oras-go: failed
> oras-go/v2: checking
< oras-go/v2: failed |
I’ll test this out today. Thank you! |
Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com>
Hey @shizhMSFT @FeynmanZhou this is the log I got after latest commit:
I think it's safe to say the issue is fixed now. Also, the URLs listed below redirects to their respective repositories: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me for other parts.
* feat: initial commit for docusaurus migration (#140) * feat: initial commit for docusaurus migration Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * use admonitions instead of block quotes Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * truncate blog post Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * use admonitions in blog post Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: add netlify.toml file Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * add netlify-plugin-cache Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * fix links Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * rename folders, add content and fix links Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * remove old docs Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> --------- Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: add announcement bar and feature section update (#145) * feat: initial commit for docusaurus migration Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * use admonitions instead of block quotes Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * truncate blog post Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * use admonitions in blog post Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: add netlify.toml file Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * add netlify-plugin-cache Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * fix links Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * rename folders, add content and fix links Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * remove old docs Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: add anouncement bar and features content Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> --------- Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * fix: redirects issue (#146) * feat: initial commit for docusaurus migration Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * use admonitions instead of block quotes Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * truncate blog post Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * use admonitions in blog post Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: add netlify.toml file Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * add netlify-plugin-cache Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * fix links Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * rename folders, add content and fix links Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * remove old docs Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: add anouncement bar and features content Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * add redirect files Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * fix redirect issues Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> --------- Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> --------- Signed-off-by: Asmit2952 <asmitbm2952002@gmail.com> Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> Co-authored-by: Asmit Malakannawar <81866614+asmitbm@users.noreply.github.com>
Created three files by following this guide and for fixing oras redirect issues.
Fixes: #141
Reference file: https://github.com/oras-project/oras-www/blob/main/docs/custom/main.html