-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations should be optional, not automatically added. #167
Comments
Reviewing the tar docs, it's not clear why we need the layer annotations. When the oras binary is used, can we be smarter about the extension used on the {
"mediaType": "application/vnd.acme.rocket.docs.layer.v1+tar",
"digest": "sha256:20ae7d51e2365405e6942439140d897548e1d4610db60354aef8a5ce1f1699a7",
"size": 196,
"annotations": {
"io.deis.oras.content.digest": "sha256:4329ea6c620ca4e9cedc5f5e8040432114cb5d64fc53107ea870db149e3d2b9e",
"io.deis.oras.content.unpack": "true",
"org.opencontainers.image.title": "docs"
}
} |
Looks like the annotations are used to persist individual files, not tars. |
I think that the original purpose of using
I believe this is incorrect, just one annotation, I agree that these should not be automatically added when using as a Go library, however it is already achievable using |
Closing as this new issue tracks the larger set of issues. |
When using the ORAS binary, it automatically adds several annotations. This was intended to be representative of what's possible, however as we consider adding to OCI as a standard library, there's valid concern that this implies a standard, as opposed to an ability.
Some of the annotations are in the "interesting" meta-data category, while others are used to determine how/where to extract compressed content. Such as a directory of files passed in.
This issue is to track removal of annotations without explicitly asking for them, and finding an alternative means for the file compression/decompression of files. Perhaps using the config object.
The text was updated successfully, but these errors were encountered: