Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add test specs for oras blob push command #587

Closed
Tracked by #564
qweeah opened this issue Sep 20, 2022 · 1 comment · Fixed by #706
Closed
Tracked by #564

e2e: add test specs for oras blob push command #587

qweeah opened this issue Sep 20, 2022 · 1 comment · Fixed by #706
Assignees
Labels
E2E testing End-to-end testing related issues or pull requests
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Sep 20, 2022

Happy paths:

  • should push a blob from stdin
  • should push a blob from a file
  • should push a blob from a file and output the descriptor
  • progress status should be disabled when --descriptor is provided
  • should show preview hint in help doc

Bad paths:

  • should fail if no blob file reference is provided
  • should fail directly if not logged in
@qweeah qweeah added the E2E testing End-to-end testing related issues or pull requests label Sep 20, 2022
@qweeah qweeah added this to the v0.16.0 milestone Sep 20, 2022
@lizMSFT
Copy link
Contributor

lizMSFT commented Sep 20, 2022

Hi @qweeah , could you also add:

Happy paths:

  • should push a blob from a file and output the descriptor with specific media-type (using --media-type)
  • should push a blob from a file and output the prettified descriptor
  • should skip the push operation if the blob already exists in the target repo

Bad paths:

  • should fail if read from input (-) and read password from input (--password-stdin) are both used
  • should fail if push a blob from stdin but either blob size (--size) or digest is not provided
  • should fail if push a blob from stdin but either blob size (--size) or digest is incorrect
  • should fail if push a blob from file but provided blob size (--size) is incorrect
  • should fail if push a blob from file but provided blob digest (name[@digest]) is incorrect

@qweeah qweeah modified the milestones: v0.16.0, v0.17.0 Nov 2, 2022
@qweeah qweeah self-assigned this Nov 28, 2022
shizhMSFT pushed a commit that referenced this issue Dec 15, 2022
Resolves #587

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@FeynmanZhou FeynmanZhou modified the milestones: v0.16.1, v1.0.0-rc.1 Jan 3, 2023
TerryHowe pushed a commit to TerryHowe/oras that referenced this issue Feb 2, 2023
Resolves oras-project#587

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E testing End-to-end testing related issues or pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants