Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show annotations in oras discover #631

Closed
shizhMSFT opened this issue Oct 4, 2022 · 6 comments · Fixed by #735
Closed

Show annotations in oras discover #631

shizhMSFT opened this issue Oct 4, 2022 · 6 comments · Fixed by #735
Assignees
Labels
enhancement New feature or request ux User experience related
Milestone

Comments

@shizhMSFT
Copy link
Contributor

Showing the annotations as a part of the OCI specification -

image

@shizhMSFT @FeynmanZhou - thoughts on how you to show annotations in the discover command -

Originally posted by @sajayantony in #630 (comment)

@shizhMSFT
Copy link
Contributor Author

@sajayantony Annotations in oras discover looks interesting. I'd like to have key: value instead of key=value printed.

We also need to find out the UX for other layouts besides tree.

@FeynmanZhou
Copy link
Member

Replied on #630 (comment).

Let me investigate this CLI UX.

@sajayantony
Copy link
Contributor

Keeping the string same enables consistent parsing across manifest and outputs is my take.

@qweeah
Copy link
Contributor

qweeah commented Oct 5, 2022

@sajayantony Annotations in oras discover looks interesting. I'd like to have key: value instead of key=value printed.

We also need to find out the UX for other layouts besides tree.

@shizhMSFT Seems key: value is not an option since datetime format might conatin :

@shizhMSFT
Copy link
Contributor Author

shizhMSFT commented Oct 5, 2022

Keeping the string same enables consistent parsing across manifest and outputs is my take.

That makes sense.

@shizhMSFT shizhMSFT reopened this Oct 5, 2022
@shizhMSFT
Copy link
Contributor Author

@qweeah The value can be anything so that we are more focusing on the UX other than the content value.
For instance, {"foo":"bar=fun"} will result in foo=bar=fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience related
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants