-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show annotations in oras discover
tree format output
#735
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 16 16
Lines 574 574
=======================================
Hits 420 420
Misses 123 123
Partials 31 31 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Will |
What's the intention of using colon? If it's for automation, then json output is definitely a better option. Since annotation key can contain a colon. If we use colon we'd better double quotes the key and value, with double quotes escaped. E.g. showing
|
It is for human readability. Basically, |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
if err != nil { | ||
return err | ||
} | ||
referrerNode.AddPathString(strings.TrimSpace(string(bytes))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason to trim space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…oject#735) Signed-off-by: Billy Zha <jinzha1@microsoft.com>
This PR enriches tree output of
oras discover
. Artifact annotations will be shown in yaml format if--verbose
flag is set.Resolves #631
Signed-off-by: Billy Zha jinzha1@microsoft.com