Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support oras login #53

Merged
merged 12 commits into from
Apr 11, 2019
Merged

Support oras login #53

merged 12 commits into from
Apr 11, 2019

Conversation

shizhMSFT
Copy link
Contributor

This PR supports

  • oras login to log in to a remote registry.
  • oras logout to log out from a remote registry.

It re-uses the auth config from docker cli, so as docker credential helpers. By default, it uses the default docker config and it can be overridden by setting the --config option. Multiple config files can be taken that if the credential is not found in the first config, oras continue to search from the next config file.

For login and logout, the credential changes always occur in the first config file (i.e. all config files except the first one are read-only).

@sajayantony @jdolitsky This is a supportive solution to helm/helm#5461

@shizhMSFT shizhMSFT added the enhancement New feature or request label Mar 29, 2019
@jdolitsky
Copy link
Contributor

/test

1 similar comment
@jdolitsky
Copy link
Contributor

/test

@jdolitsky jdolitsky self-requested a review April 11, 2019 05:35
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with registry and works perfectly. Please see also #60

@jdolitsky
Copy link
Contributor

/test

@shizhMSFT
Copy link
Contributor Author

/test

@shizhMSFT shizhMSFT merged commit 1829eb0 into master Apr 11, 2019
@shizhMSFT shizhMSFT deleted the shizh/auth branch April 11, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants