feat: support excluding digest tags #668
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 72.12% 72.12%
=======================================
Files 14 14
Lines 513 513
=======================================
Hits 370 370
Misses 114 114
Partials 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
qweeah
changed the title
cmd/oras/repository/show-tags.go
Outdated
| @@ -52,6 +55,7 @@ Example - Show tags of the target repository that include values lexically after | |||
| }, | |||
| } | |||
| cmd.Flags().StringVar(&opts.last, "last", "", "start after the tag specified by `last`") | |||
| cmd.Flags().BoolVar(&opts.excludeDigestTag, "exclude-digest-tag", false, "exclude all digest tags created by OCI artifact tag schema") | |||
There was a problem hiding this comment.
nit: maybe "referrers tag schema"?🤔
There was a problem hiding this comment.
I might need to rephrase this and add example latter, maybe without mentioning referrer or tag schema, below is why:
The use case of this flag is: one user found that oras repo tags is listing out some unexpected tags, he/she want to hide them. The struggling point is: how does this user know about the unwanted tags?
- If he/she knows well of the distribution spec, then we only need to make the flag name explainative on the behavior of filtering or hidden
- If he/she knows nothing of the distribution spec(most users don't), then mentioning
referrersortag schemain the long description won't help them realize that this flag is what they need to use.
There was a problem hiding this comment.
I agree. The users don't need to know anything about the referrers implementation.
There was a problem hiding this comment.
Brainstorming: How about "metadata tags"?
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Making this PR draft since I found that it's important to write good example and long description for the new flag. Resolves oras-project#658 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Making this PR draft since I found that it's important to write good example and long description for the new flag.
Resolves #658
Signed-off-by: Billy Zha jinzha1@microsoft.com