Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add ORAS CLI proposal doc for compatibility mode #739

Merged
merged 10 commits into from
Jan 30, 2023

Conversation

FeynmanZhou
Copy link
Member

Adding a CLI design proposal to solve #720

Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Merging #739 (9addaa3) into main (735ce35) will decrease coverage by 2.32%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   63.86%   61.54%   -2.32%     
==========================================
  Files          19       20       +1     
  Lines         714      801      +87     
==========================================
+ Hits          456      493      +37     
- Misses        225      268      +43     
- Partials       33       40       +7     
Impacted Files Coverage Δ
internal/graph/graph.go 42.52% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FeynmanZhou FeynmanZhou changed the title doc: add ORAS CLI proposal doc doc: add ORAS CLI proposal doc for compatibility mode Jan 10, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
@FeynmanZhou FeynmanZhou requested review from qweeah, shizhMSFT, yizha1 and a team January 10, 2023 10:33
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
shizhMSFT pushed a commit that referenced this pull request Jan 13, 2023
Resolves #739

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@FeynmanZhou FeynmanZhou reopened this Jan 16, 2023
@shizhMSFT shizhMSFT added this to the v1.0.0-rc.1 milestone Jan 20, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Outdated Show resolved Hide resolved
docs/proposals/compatibility-mode.md Show resolved Hide resolved
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 9360104 into oras-project:main Jan 30, 2023
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Resolves oras-project#739

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants