-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: force deleting a non-existent blob/manifest #745
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
=======================================
Coverage 73.46% 73.46%
=======================================
Files 17 17
Lines 588 588
=======================================
Hits 432 432
Misses 125 125
Partials 31 31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggestions.
} | ||
|
||
// ApplyFlags applies flags to a command flag set. | ||
func (opts *Confirmation) ApplyFlags(fs *pflag.FlagSet) { | ||
fs.BoolVarP(&opts.Confirmed, "force", "f", false, "do not prompt for confirmation") | ||
fs.BoolVarP(&opts.Force, "force", "f", false, "do not prompt for confirmation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we consider ignore non-existent references, never prompt
over do not prompt for confirmation
? /cc @FeynmanZhou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Also nonexistent is a word and is already used by rm
manual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @shizhMSFT 's suggestion. I see @qweeah has incorporated it into the confirmation.
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves oras-project#722 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Resolves oras-project#722 Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Resolves #722
Signed-off-by: Billy Zha jinzha1@microsoft.com