Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: show subject digest in oras discover #798

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Feb 10, 2023

Changes in this PR prints resolved digest for root node of tree-view output in oras discover.

Resolves #789

Signed-off-by: Billy Zha jinzha1@microsoft.com

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review February 10, 2023 10:20
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #798 (416a68d) into main (6fe1271) will decrease coverage by 7.22%.
The diff coverage is 51.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   62.71%   55.50%   -7.22%     
==========================================
  Files          20       23       +3     
  Lines         802      935     +133     
==========================================
+ Hits          503      519      +16     
- Misses        257      374     +117     
  Partials       42       42              
Impacted Files Coverage Δ
cmd/oras/internal/option/target.go 20.22% <0.00%> (-1.47%) ⬇️
cmd/oras/repository/ls.go 27.11% <64.00%> (ø)
cmd/oras/repository/cmd.go 0.00% <0.00%> (ø)
cmd/oras/repository/tags.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 0866598 into oras-project:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ORAS discover consistent with 0.16
3 participants