Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard logger #80

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Discard logger #80

merged 1 commit into from
Apr 18, 2019

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Apr 17, 2019 •
edited

Discard logger by default unless --debug is toggled.

@jdolitsky Take a look at pkg/context/logger.go. You may need WithLoggerFromWriter() or WithLoggerDiscarded() for helm 3.

Resolves #72

@shizhMSFT
Copy link
Contributor Author

/test

@shizhMSFT shizhMSFT mentioned this pull request Apr 17, 2019
Closed
jdolitsky
jdolitsky approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me!

@shizhMSFT shizhMSFT merged commit d1e0198 into master Apr 18, 2019
@shizhMSFT shizhMSFT deleted the shizh/log branch April 18, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdolitsky jdolitsky jdolitsky approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony

@bacongobbler bacongobbler Awaiting requested review from bacongobbler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No warnings in the output
2 participants
@shizhMSFT @jdolitsky