feat: add retry support to the auth client #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
requested review from
deitch,
jdolitsky,
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
qweeah
reviewed
Feb 27, 2023
qweeah
reviewed
Feb 27, 2023
qweeah
reviewed
Feb 27, 2023
qweeah
requested changes
Feb 27, 2023
qweeah
reviewed
Feb 27, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #838 +/- ##
==========================================
+ Coverage 67.46% 67.54% +0.07%
==========================================
Files 21 21
Lines 873 875 +2
==========================================
+ Hits 589 591 +2
Misses 239 239
Partials 45 45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TerryHowe
reviewed
Feb 27, 2023
shizhMSFT
changed the title
If implemented the assembled oras auth client will have the default retry policy set for the underlying http roundTripper. Signed-off-by: Soule BA <bah.soule@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If implemented the assembled
oras auth clientwill have the default retry policy set for the underlying http roundTripper.Which issue(s) this PR fixes:
Fixes #769
Please check the following list: