Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UX on Push / Pull #84

Merged
merged 8 commits into from
Apr 19, 2019
Merged

Better UX on Push / Pull #84

merged 8 commits into from
Apr 19, 2019

Conversation

shizhMSFT
Copy link
Contributor

@shizhMSFT shizhMSFT commented Apr 18, 2019

Enhance user experience on Push and Pull. Resolves #77.

$ oras push localhost:5000/club:party cake.txt juice.txt
Uploading be6fe1187628 juice.txt
Uploading 22af0898315a cake.txt
Pushed localhost:5000/club:party
Digest: sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998
$ oras pull localhost:5000/club:party
Downloaded be6fe1187628 juice.txt
Downloaded 22af0898315a cake.txt
Pulled localhost:5000/club:party
Digest: sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998

With verbose:

$ oras push -v localhost:5000/club:party cake.txt juice.txt
Preparing cake.txt
Preparing juice.txt
Uploading be6fe1187628 juice.txt
Uploading 22af0898315a cake.txt
Pushed localhost:5000/club:party
Digest: sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998
$ oras pull -v localhost:5000/club:party
WARN[0000] unknown type: application/vnd.oci.image.config.v1+json
Downloaded be6fe1187628 juice.txt
Downloaded 22af0898315a cake.txt
Pulled localhost:5000/club:party
Digest: sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998

Pushing / pulling without a tag is also allowed. Fixes #79.

$ oras push localhost:5000/club cake.txt juice.txt
Uploading be6fe1187628 juice.txt
Uploading 22af0898315a cake.txt
Pushed localhost:5000/club
Digest: sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998
$ oras pull localhost:5000/club@sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998
Downloaded be6fe1187628 juice.txt
Downloaded 22af0898315a cake.txt
Pulled localhost:5000/club@sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998
Digest: sha256:5c46f904baecbd34f1a261e67200faed4bb0a904d152af3cdd7c9a57ac017998

Note

We are not able to know whether individual file is uploaded or not as it is limited by the stable version of containerd (v1.2.6) with detailed code at here. We can have a better UX in the next version of oras once containerd has new releases (their current master branch does not limit us).

@shizhMSFT shizhMSFT added the enhancement New feature or request label Apr 18, 2019
@shizhMSFT
Copy link
Contributor Author

/test

Copy link
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shizhMSFT shizhMSFT merged commit 4223f0b into master Apr 19, 2019
@shizhMSFT shizhMSFT deleted the shizh/verbose branch April 19, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push without an tag Make push/pull information out of verbose
2 participants