refactor: clone default http transport for registry client #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
requested review from
deitch,
jdolitsky,
sajayantony,
shizhMSFT,
SteveLasker and
TerryHowe
as code owners
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
changed the title
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #840 +/- ##
=======================================
Coverage ? 66.47%
=======================================
Files ? 21
Lines ? 859
Branches ? 0
=======================================
Hits ? 571
Misses ? 242
Partials ? 46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Feb 28, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
force-pushed
the
refactor-dailer
branch
from
a4f3e22
to
f285a0c
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Mar 2, 2023
… refactor-dailer Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes hard-coded transport declaration in registry client.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #839
Please check the following list: