Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push bug when multi tagging #850

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Mar 2, 2023

What this PR does / why we need it:
This PR fixes a bug in oras push.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #849

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #850 (6ff560c) into main (8c238a9) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ff560c differs from pull request most recent head 244c0f7. Consider uploading reports for the commit 244c0f7 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files          21       21           
  Lines         879      879           
=======================================
  Hits          588      588           
  Misses        245      245           
  Partials       46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit d93544d into oras-project:main Mar 2, 2023
@qweeah qweeah deleted the fix-push branch March 2, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oras push fails when multiple tags are provided
3 participants