Encoding check #87
Merged
Encoding check #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
shizhMSFT
requested changes
Apr 19, 2019
Signed-off-by: Josh Dolitsky <jdolitsky@gmail.com>
|
/test |
shizhMSFT
approved these changes
Apr 19, 2019
|
/test |
|
@jdolitsky I have updated the yaml files for codefresh. We are now using smaller image |
shizhMSFT
reviewed
Apr 19, 2019
| - &link ln -s /codefresh/volume/${{CF_REPO_NAME}} ${{CF_REPO_NAME}} && cd ${{CF_REPO_NAME}} | ||
| - echo make test |
There was a problem hiding this comment.
I don't why there is an echo. Feel free to revert it.
There was a problem hiding this comment.
must have been from an earlier test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for checking line-endings, also command to fix line endings.
Fixes #86