-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement dynamic modules #156
Conversation
# Conflicts: # src/CoreServer.cpp
{ | ||
|
||
_logger = spdlog::get("visor"); | ||
if (!_logger) { | ||
_logger = spdlog::stderr_color_mt("visor"); | ||
} | ||
|
||
// inputs | ||
_input_manager = std::make_unique<InputStreamManager>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a question: is this module dynamically loaded? If so, I didn't get how it is created before it os loaded @weyrick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this one is static and part of core code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, nice
add Dynamic Module support. adds
--module-list
,--module-load
, and--module-dir
command line options, plus a sample dynamic Mock Handler module.