Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/99 yaml config all cmd options #159

Merged
5 commits merged into from
Dec 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2021

- Fix typo when loading module. VisorHandlerMock test passing
- Add modules configuration on config file
- Add CmdOption struct with possible cmd option to pkvisor main file
- Check config file and args before validating and executing each option
- Prioritize cmd options over config file

Leonardo Parente added 4 commits December 9, 2021 18:06
    - Add CmdOption struct with possible cmd option to pkvisor main file
    - Check config file and args before validating and executing each option
    - Prioritize cmd options over config file
Copy link
Member

@weyrick weyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one request: the rest of the YAML config files use underscores instead of dashes, so please change the config file version of the options to use underscore, e.g. "log_file" instead of "log-file"

@ghost ghost linked an issue Dec 10, 2021 that may be closed by this pull request
@ghost ghost merged commit 1fb8222 into develop Dec 10, 2021
@ghost ghost deleted the feature/99-yaml-config-all-cmd-options branch December 10, 2021 19:43
weyrick added a commit that referenced this pull request Dec 27, 2021
weyrick added a commit that referenced this pull request Dec 27, 2021
fix a few typos introduced in PR #159
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pktvisor command line options to config file
1 participant