Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/166 module handlers sequence #169

Merged
7 commits merged into from
Jan 7, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 6, 2022

No description provided.

@ghost ghost linked an issue Jan 6, 2022 that may be closed by this pull request
5 tasks
@ghost ghost requested a review from weyrick January 6, 2022 18:36
Copy link
Member

@weyrick weyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just a few minor changes for clarity.

cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
src/handlers/dhcp/DhcpStreamHandler.cpp Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.cpp Show resolved Hide resolved
@ghost ghost merged commit 416010b into develop Jan 7, 2022
@ghost ghost deleted the feature/166-module-handlers-sequence branch January 7, 2022 13:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC 76 update: accept both a map and an array of handlers at "modules" key, implement chaining
1 participant