Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique name for TopN metrics #183

Merged
4 commits merged into from
Jan 19, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 19, 2022

No description provided.

@ghost ghost requested a review from weyrick January 19, 2022 16:18
src/Metrics.h Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.cpp Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.h Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.h Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.h Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.h Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.h Outdated Show resolved Hide resolved
src/handlers/dns/DnsStreamHandler.h Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jan 19, 2022

This PR changes the aggregated qname dns to lower case. This changes the qname cardinality as well.

@ghost ghost merged commit 8282af7 into develop Jan 19, 2022
@ghost ghost deleted the feature/topn-unique-name-per-metric branch January 19, 2022 19:17
@weyrick weyrick linked an issue Jan 25, 2022 that may be closed by this pull request
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus "name" label in top K metric should be unique per metric
1 participant