Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike/otel proto #584

Merged
merged 19 commits into from
Jan 3, 2023
Merged

Spike/otel proto #584

merged 19 commits into from
Jan 3, 2023

Conversation

leoparente
Copy link
Collaborator

No description provided.

@leoparente leoparente self-assigned this Dec 19, 2022
@leoparente leoparente linked an issue Dec 19, 2022 that may be closed by this pull request
Spike - Opentelemetry client #553
Closed
@leoparente leoparente marked this pull request as ready for review December 21, 2022 17:55
weyrick
weyrick requested changes Dec 22, 2022
View reviewed changes
Copy link
Member

@weyrick weyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really great work! it's a shame that so much of this is repetition and copy/paste from json/prom code (especially all the new duplicate logic involving groups in the handlers) ... we will have to save that as tech debt for now

cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
cmd/pktvisord/main.cpp Outdated Show resolved Hide resolved
src/OpenTelemetry.h Outdated Show resolved Hide resolved
src/OpenTelemetry.h Outdated Show resolved Hide resolved
src/Policies.cpp Outdated Show resolved Hide resolved
@leoparente
Copy link
Collaborator Author

leoparente commented Dec 23, 2022 •
edited

this is really great work! it's a shame that so much of this is repetition and copy/paste from json/prom code (especially all the new duplicate logic involving groups in the handlers) ... we will have to save that as tech debt for now

Agree. I think we could find a way to use template to handle to_json/prom/otel functions

@leoparente leoparente added enhancement New feature or request design labels Dec 23, 2022
@leoparente leoparente merged commit 4701e9a into develop Jan 3, 2023
@leoparente leoparente deleted the spike/otel-proto branch January 3, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyrick weyrick weyrick approved these changes

Assignees

@leoparente leoparente

Labels
design enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spike - Opentelemetry client
2 participants
@leoparente @weyrick