Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current dependencies to latest #687

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Update current dependencies to latest #687

merged 2 commits into from
Sep 18, 2023

Conversation

leoparente
Copy link
Collaborator

@leoparente leoparente commented Sep 12, 2023

Updates in dependencies

  • [requires]
    benchmark/1.7.0 -> benchmark/1.8.3
    catch2/2.13.9 -> catch2/2.13.10
    cpp-httplib/0.11.2 -> cpp-httplib/0.14.0
    fmt/8.1.1 -> removed (let spdlog define fmt version)
    opentelemetry-proto/0.19.0 -> opentelemetry-proto/1.0.0
    protobuf/3.19.2 -> protobuf/3.21.12
    sigslot/1.2.1 -> sigslot/1.2.2
    spdlog/1.11.0 -> spdlog/1.12.0
    libpcap/1.10.1 -> libpcap/1.10.4
    yaml-cpp/0.7.0 -> yaml-cpp/0.8.0
    zlib/1.2.12 -> zlib/[>=1.2.10 <1.3]

  • renamed [build_requires] to [tool_requires] based on 1.X conan documentation

  • add [generators] cmake_find_package : which generates the Find{pkg}.cmake automatically, so FindCorrade.cmake is not necessary anymore (removed)

Required changes

  • fmt v10.X.X required explicit known types, so some logs/messages needed to be changed.
  • updated cmake for opentelemetry-proto based on the official opentelemetry-cpp/cmake files.
  • Change CMakeFiles: remove some not necessary code and add proper code to match conan cmake_find_package usage

Test Required!

  • opentelemetry proto was updated from 0.19.0 to the stable version 1.0.0, this requires a proper validation of pktvisor and its integration with orb (end to end validation) to check if there is no impact in metrics.

Next Steps

  • uvw and catch2 upgrades have breaking changes, so I will perform those in separated PRs.

@leoparente leoparente marked this pull request as ready for review September 15, 2023 18:21
Copy link
Member

@weyrick weyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@etaques etaques merged commit a2bfaab into orb-community:develop Sep 18, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants