Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/loading screen #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature/loading screen #43

wants to merge 5 commits into from

Conversation

Laurell876
Copy link
Contributor

@Laurell876 Laurell876 commented Mar 3, 2021

Example of how loading screen looks when the user clicks the rendered button

updated loader

@Laurell876 Laurell876 self-assigned this Mar 3, 2021
@Laurell876 Laurell876 linked an issue Mar 3, 2021 that may be closed by this pull request
@Laurell876 Laurell876 requested a review from heyjordn March 3, 2021 20:11
Copy link
Contributor

@heyjordn heyjordn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick to the established conventions. Why would we pollute the main typescript file with all of this markdown, this makes this file near impossible to read and understand

@@ -10,7 +11,121 @@ function initializeVerification(config: OrbaOneConfig, button: ReturnType<typeof

//Set Loading state
button.setState("loading");
loadingDiv.innerHTML = `
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ridiculous, why are cluttering the main index file with all of this markdown?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iframe Loading Screen
2 participants