Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xxf:r() must support indexes #1328

Closed
ebruchez opened this issue Oct 15, 2013 · 5 comments
Closed

xxf:r() must support indexes #1328

ebruchez opened this issue Oct 15, 2013 · 5 comments

Comments

@ebruchez
Copy link
Collaborator

Goal: support multiple alerts.

  • local branch 2013-07-01-update-xxf-r-to-support-indexes
  • alert format for later: xxf:r('control-1.alert.2')
  • FB/FR must support using xxf:r()
@ebruchez
Copy link
Collaborator Author

Needed for #1342.

@ebruchez
Copy link
Collaborator Author

ebruchez commented Jun 26, 2017

  • Q: Index from 0 or from 1?
    • → let's pick 0
  • implement search
  • implement PathMap
  • unit tests for xxf:r()
    • Scala tests of path evaluation
    • XPath dependencies test

ebruchez added a commit that referenced this issue Jun 29, 2017
@ebruchez ebruchez added this to Missing Doc in Orbeon Forms 2017.2 Jun 29, 2017
@ebruchez ebruchez reopened this Jun 30, 2017
@ebruchez
Copy link
Collaborator Author

After discussion:

  • change the syntax to control-1.alert[2]

This makes things more consistent with the XPath and JavaScript syntaxes for indexes.

@ebruchez ebruchez moved this from Missing Doc to In Progress in Orbeon Forms 2017.2 Dec 1, 2017
@ebruchez ebruchez removed this from In Progress in Orbeon Forms 2017.2 Dec 4, 2017
@ebruchez ebruchez removed this from the 2017.2 milestone Dec 4, 2017
@ebruchez
Copy link
Collaborator Author

ebruchez commented May 24, 2018

For #1342, we moved to using nested <fr:param> within <xf:label>, etc. But at runtime, we convert that to using xxf:r(). Right now, for LHH, we use control-name.label, etc., but we will need the .2 or [2] syntax for supporting alerts. So this goes hand in hand with supporting dynamic alert messages with #3628.

@ebruchez ebruchez added this to To Review in Orbeon Forms 2018.1 May 24, 2018
@ebruchez ebruchez moved this from To Review to In Progress in Orbeon Forms 2018.1 May 24, 2018
@ebruchez
Copy link
Collaborator Author

Since support for dynamic alert messages has moved to #3628, we can postpone updating the syntax as well.

@ebruchez ebruchez removed this from In Progress in Orbeon Forms 2018.1 Jul 30, 2018
@ebruchez ebruchez added this to To Review in Orbeon Forms 2018.2 Jul 31, 2018
@ebruchez ebruchez moved this from To Review to Missing Doc in Orbeon Forms 2018.2 Nov 28, 2018
@ebruchez ebruchez closed this as completed Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Orbeon Forms 2018.2
  
Missing Doc
Development

No branches or pull requests

1 participant