Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to move/reorder grids up/down within/across sections #1845

Closed
Tracked by #1675
ebruchez opened this issue Jul 31, 2014 · 18 comments
Closed
Tracked by #1675

Ability to move/reorder grids up/down within/across sections #1845

ebruchez opened this issue Jul 31, 2014 · 18 comments

Comments

@ebruchez
Copy link
Collaborator

Curiously, this is not supported right now. It seems like a very basic feature!

See also #635 for other grid-related improvements.

+1 from customer (private email)

@ebruchez ebruchez added this to the Consider for 4.8 milestone Jul 31, 2014
@ebruchez
Copy link
Collaborator Author

Ideally, this would be done with DnD. If not, at least arrows as we do for sections.

@ebruchez
Copy link
Collaborator Author

+1 from other customer

@avernet avernet removed this from the Consider for 4.8 milestone Oct 17, 2014
@ebruchez ebruchez removed this from the Consider for 4.8 milestone Oct 17, 2014
@ajw625
Copy link
Contributor

ajw625 commented Feb 26, 2015

This is definitely something we need. We've found the process rather painful when reordering grids or simply adding a grid at the beginning of a section.

@ebruchez
Copy link
Collaborator Author

@ajw625 Agreed. We haven't yet scheduled this enhancement though.

@avernet avernet changed the title Ability to move grids up/down within sections Ability to move/reorder grids up/down within sections Apr 22, 2015
@avernet
Copy link
Collaborator

avernet commented Apr 22, 2015

+1 from customer

@avernet avernet added this to the 4.10 milestone Apr 22, 2015
@acspike
Copy link
Contributor

acspike commented May 13, 2015

Adding move triggers is trivial (see #2228), but as with #2226 there is a problem with space. The grid delete trigger is surrounded on all sides. Would it be possible to add a dropdown menu similar to the menu used in repeating grids?

@ajw625, I think I've been able to successfully reorder grids using the source editor. Not pretty, but better than copying and pasting many controls.

@ebruchez
Copy link
Collaborator Author

Ideally, I would like:

  • icons for discoverability of the feature
  • drag and drop so we can move faster and with more flexibility
  • keyboard shortcut to move the current grid (and other objects)

It would be good to have the ability to show more icons without being limited by the space within the grid or grid cell. There could be a "palette" of actions showing outside the boundary of the grid.

@ebruchez
Copy link
Collaborator Author

+1 from evaluator

@avernet
Copy link
Collaborator

avernet commented Sep 14, 2015

+1 from customer

@avernet avernet changed the title Ability to move/reorder grids up/down within sections Ability to move/reorder grids up/down within/accros sections Sep 14, 2015
@ebruchez
Copy link
Collaborator Author

ebruchez commented Mar 8, 2016

+1 from me today. If UI takes a while to implement, maybe can implement keyboard shortcuts first, which is a workaround for beginners, but great for power users (#233).

@ebruchez
Copy link
Collaborator Author

Another idea until we get proper DnD: do this via buttons within the Grid Settings dialog.

Currently, there is no such dialog for non-repeated grids, but we should have one, see some steps under #1947.

@ebruchez ebruchez changed the title Ability to move/reorder grids up/down within/accros sections Ability to move/reorder grids up/down within/across sections Mar 23, 2016
@ebruchez ebruchez self-assigned this Apr 22, 2016
@ebruchez ebruchez added this to the 2016.2 milestone Apr 22, 2016
@ebruchez ebruchez modified the milestones: 2016.3, 2016.2 May 16, 2016
@Syncopatico
Copy link

Hi Erik - as per comment elsewhere, for long lists (e.g, where range of move won't fit on screen), a 'move to before/after ...' option may be more usable than drag and drop. BTW - is this still just for grid items witihin Form Builder, or for end-user actions with repeating grid items in Form Runner?

@ebruchez
Copy link
Collaborator Author

@Syncopatico Good suggestion. This issue is about Form Builder specifically.

@ebruchez
Copy link
Collaborator Author

See also #2461. We now have some experience with drag and drop so we should be able to do this fairly easily.

@ebruchez
Copy link
Collaborator Author

The main question is about the UI for this, namely where can you click and grab so it's clear what's happening. Right now, on hover, we show icons, but those are not inserted into the DOM but instead positioned absolutely, on the side. So we probably cannot use that area as handles for Dragula, which I think requires nesting (but need to confirm this).

@ebruchez
Copy link
Collaborator Author

Next step:

  • quick try: would naive solution which detects click on grid be usable for a first implementation

@ebruchez ebruchez modified the milestones: 2017.1, 2016.3 Dec 5, 2016
@ebruchez ebruchez modified the milestones: 2017.2, 2017.1 Apr 10, 2017
@ebruchez ebruchez added this to Backlog in Orbeon Forms 2017.2 Jun 9, 2017
@ebruchez ebruchez removed this from To Review in Orbeon Forms 2017.2 Dec 4, 2017
@ebruchez ebruchez removed this from the 2017.2 milestone Dec 4, 2017
@ebruchez ebruchez added this to To Do in Orbeon Forms 2018.1 Jan 3, 2018
@ebruchez ebruchez removed this from To Do in Orbeon Forms 2018.1 May 24, 2018
@ebruchez
Copy link
Collaborator Author

+1 again

@ebruchez
Copy link
Collaborator Author

Implemented with arrows for now. Added #4088 for DnD.

@ebruchez ebruchez added this to Done in Orbeon Forms 2019.1 via automation Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants