Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Email Recipient", "Show in Email Subject", and attachments don't work in section templates #2016

Closed
avernet opened this issue Dec 4, 2014 · 4 comments
Assignees
Milestone

Comments

@avernet
Copy link
Collaborator

avernet commented Dec 4, 2014

To reproduce, use the form and library provided by Martin in this thread.

@avernet
Copy link
Collaborator Author

avernet commented Dec 4, 2014

+1 from community

@avernet avernet changed the title "Email Recipient" field doesn't if in a section template "Email Recipient" field doesn't work if in a section template Dec 4, 2014
@ebruchez
Copy link
Collaborator

ebruchez commented Dec 4, 2014

  • problem: email service doesn't have access to live document, and gets fr-email-recipient from form definition source
  • BUT email is always run from live document, and call to email service could pass email recipients as URL parameters
  • while at it, do this for fr-email-subject as well
  • attachments within section templates too won't work
    • should we pass them?
    • or just guess them from data, as we do in other cases I think?

@ebruchez ebruchez added this to the 4.10 milestone Jun 8, 2015
@ebruchez
Copy link
Collaborator

ebruchez commented Jun 8, 2015

+1 from customer

@ebruchez
Copy link
Collaborator

ebruchez commented Jul 7, 2015

I see two ways of doing this:

  1. using the live document to inspect controls and find the ones with a given class
    • this requires that we have an ability to iterate controls and/or find those with a given class, which I don't think we have now so would need to be added
    • then the list of values associated with these controls must be passed to the email service
  2. keep things the way they are but inspect section templates XBL

I think option 2 might be easier.

@ebruchez ebruchez changed the title "Email Recipient" field doesn't work if in a section template "Email Recipient", "Show in Email Subject", and attachments don't work in section templates Jul 7, 2015
ebruchez added a commit that referenced this issue Jul 7, 2015
- buildBindPath now parenthesizes paths
- not strictly needed as all our paths are simple, but more correct
ebruchez added a commit that referenced this issue Jul 8, 2015
ebruchez added a commit that referenced this issue Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants