Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML labels/hints have <br clear="none"> #2099

Closed
umwmcomarch opened this issue Feb 18, 2015 · 5 comments
Closed

HTML labels/hints have <br clear="none"> #2099

umwmcomarch opened this issue Feb 18, 2015 · 5 comments
Assignees
Milestone

Comments

@umwmcomarch
Copy link

Current version of Orbeon - 4.8 and previous has error in html labels and hints. If we enter html label with html short tags for example "test<br/>test2", Orbeon changes short tags, to open tags without close tags. Created by Orbeon open tag has extra attributtes (clear="none"), which wasn't entered. Moreover from one short tag, Orbeon creates two start tags. If we copy control after that changes, Orbeon on paste add next open tag of short tag - for this example we entered one <br/>, which was changed to two <br clear="none">, after copy and paste that control we have three <br clear="none">

@acspike
Copy link
Contributor

acspike commented Feb 18, 2015

This was also mentioned on twitter.

Please see:

@avernet
Copy link
Collaborator

avernet commented Feb 19, 2015

Yes, this sounds like the issue @acspike is referring to. Since we already have "our own" version of TagSoup, I'll just change the definition file accordingly to avoid this, and update the jar in Orbeon Forms.

@avernet avernet self-assigned this Feb 19, 2015
@avernet avernet added this to the 4.8.2 milestone Feb 19, 2015
@umwmcomarch
Copy link
Author

One problem is 'clear="none"', and the second extra open tags without close tags adding after edit label or copy/paste control.

@ebruchez ebruchez modified the milestones: 4.9, 4.8.2 Mar 17, 2015
@ebruchez ebruchez changed the title Bug in html labels and hints HTML labels/hints have <br clear="none"> Mar 18, 2015
@avernet
Copy link
Collaborator

avernet commented Mar 26, 2015

With this change in TagSoup, if you enter test<br/>test2, in HTML you'll have test<br>test2.

@acspike
Copy link
Contributor

acspike commented Mar 26, 2015

Does this also correct the doubling? (<br/> was becoming <br clear="none"><br>) (#2177)

ebruchez added a commit that referenced this issue Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants