Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Review" makes all the sections accessible in wizard validated mode #2253

Closed
avernet opened this issue Jun 5, 2015 · 4 comments
Closed

"Review" makes all the sections accessible in wizard validated mode #2253

avernet opened this issue Jun 5, 2015 · 4 comments

Comments

@avernet
Copy link
Collaborator

avernet commented Jun 5, 2015

We need a mechanism not to show the review and save buttons, unless we are on the last page.

+1 from community

@avernet avernet changed the title "Review" makes all the section accessible in wizard validated mode "Review" makes all the sections accessible in wizard validated mode Jun 5, 2015
@ebruchez
Copy link
Collaborator

+1 from customer

@ebruchez
Copy link
Collaborator

ebruchez commented Jan 4, 2016

What is the ideal mechanism to achieve this? What we want to say is: "Hide or disable this button until such and such condition is met."

That condition here is transient: it's whether the user has reached (we use xxf:visited()) the last page of the wizard. Only the wizard knows the id to check to know whether the last section is visited.

How can we let the button know about this condition? I would think we would want to express that in terms of a function like fr:wizard-reached-last-page().

@ebruchez
Copy link
Collaborator

ebruchez commented Jan 4, 2016

+1 from user

@avernet avernet added this to the 4.11 milestone Jan 6, 2016
@ebruchez
Copy link
Collaborator

My comment above is not necessarily wrong. We have at least 2 different possibilities:

  1. Show the button if all sections have been visited.
  2. Show the button only when we are on the last page of the wizard.

We already expose publicly the fr-wizard-prev and fr-wizard-next buttons, which are within the wizard, and make them accessible via xxf:binding() so we can have external buttons which are enabled/disabled at the same time.

We could have another such public binding which controls the visibility of a wizard-submit button, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants