Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB: Consider migrating fr:dropdown-select1 and fr:image #2436

Open
4 tasks
ebruchez opened this issue Nov 16, 2015 · 1 comment
Open
4 tasks

FB: Consider migrating fr:dropdown-select1 and fr:image #2436

ebruchez opened this issue Nov 16, 2015 · 1 comment
Assignees

Comments

@ebruchez
Copy link
Collaborator

When we introduced fr:dropdown-select1, the XForms engine did not have native support for matching on appearance or other attributes. Since #1936 this is supported, and since #2241 bindings in the XForms namespace are supported. So we should be able to directly use xf:select1[@appearance = 'minimal'] in the form source.

Similarly, xf:output[@mediatype = 'image/*'] maps to fr:image.

Tasks:

  • implement migration back to xf:select1[@appearance = 'minimal'] in annotate.xpl
    • check that Form Builder behaves properly (toolbox, FB dialogs, appearance selector)
  • consider whether using xf:output[@mediatype = 'image/*'] would be better than keeping fr:image
  • implement migration back to xf:output[@mediatype = 'image/*'] in annotate.xpl
@ebruchez
Copy link
Collaborator Author

ebruchez commented Aug 3, 2021

Form Builder should standardize on the representation with appearance="dropdown".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant