Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML labels present in view mode #3089

Closed
ebruchez opened this issue Jan 27, 2017 · 2 comments
Closed

HTML labels present in view mode #3089

ebruchez opened this issue Jan 27, 2017 · 2 comments

Comments

@ebruchez
Copy link
Collaborator

+1 from customer

@ebruchez
Copy link
Collaborator Author

Also look at extra markup which includes lots of <span> elements.

@ebruchez
Copy link
Collaborator Author

ebruchez commented Feb 10, 2017

Analysis from Controls form:

  • P1
    • <label for="...">
      • for doesn't refer to any id
      • there shouldn't be a <label> as there are no HTML form controls (just use a <span>)
    • hints are hidden via CSS, but they should probably not be output in the first place
      • especially empty hints
    • same for alerts
    • same for help
    • <label> around static readonly checkboxes/radio buttons
    • check if, for PDF, we had a requirement to show hints in some cases
  • P2 (not directly related)
    • would it be better if instead of:
      <div class="xbl-component xbl-fr-grid">
          <div class="fr-grid fr-grid-2 fr-norepeat">
      we had:
      <div class="xbl-component xbl-fr-grid fr-grid fr-grid-2 fr-norepeat">
  • misc (not directly related)
    • fr-form-group should be a div

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant