New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML labels present in view mode #3089

Closed
ebruchez opened this Issue Jan 27, 2017 · 2 comments

Comments

Projects
1 participant
@ebruchez
Collaborator

ebruchez commented Jan 27, 2017

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Jan 27, 2017

Collaborator

Also look at extra markup which includes lots of <span> elements.

Collaborator

ebruchez commented Jan 27, 2017

Also look at extra markup which includes lots of <span> elements.

@ebruchez

This comment has been minimized.

Show comment
Hide comment
@ebruchez

ebruchez Feb 10, 2017

Collaborator

Analysis from Controls form:

  • P1
    • <label for="...">
      • for doesn't refer to any id
      • there shouldn't be a <label> as there are no HTML form controls (just use a <span>)
    • hints are hidden via CSS, but they should probably not be output in the first place
      • especially empty hints
    • same for alerts
    • same for help
    • <label> around static readonly checkboxes/radio buttons
    • check if, for PDF, we had a requirement to show hints in some cases
      • A: Yes, at least one customer shows hints in the PDF via CSS.
      • Entered #3118.
  • P2 (not directly related)
    • would it be better if instead of:
      <div class="xbl-component xbl-fr-grid">
          <div class="fr-grid fr-grid-2 fr-norepeat">
      we had:
      <div class="xbl-component xbl-fr-grid fr-grid fr-grid-2 fr-norepeat">
  • misc (not directly related)
    • fr-form-group should be a div
Collaborator

ebruchez commented Feb 10, 2017

Analysis from Controls form:

  • P1
    • <label for="...">
      • for doesn't refer to any id
      • there shouldn't be a <label> as there are no HTML form controls (just use a <span>)
    • hints are hidden via CSS, but they should probably not be output in the first place
      • especially empty hints
    • same for alerts
    • same for help
    • <label> around static readonly checkboxes/radio buttons
    • check if, for PDF, we had a requirement to show hints in some cases
      • A: Yes, at least one customer shows hints in the PDF via CSS.
      • Entered #3118.
  • P2 (not directly related)
    • would it be better if instead of:
      <div class="xbl-component xbl-fr-grid">
          <div class="fr-grid fr-grid-2 fr-norepeat">
      we had:
      <div class="xbl-component xbl-fr-grid fr-grid fr-grid-2 fr-norepeat">
  • misc (not directly related)
    • fr-form-group should be a div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment