Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send Content-Type: none for GET requests #3680

Closed
avernet opened this issue Aug 16, 2018 · 1 comment
Closed

Don't send Content-Type: none for GET requests #3680

avernet opened this issue Aug 16, 2018 · 1 comment
Labels
Module: XForms
Projects
Orbeon Forms 2018.1

Comments

@avernet
Copy link
Collaborator

avernet commented Aug 16, 2018

I am not sure if sending such a header for GET requests violates a spec, but since the header specifies the content type of the body, and GET requests doesn't have a body, the header is at best unhelpful. Also, browsers (Chrome, Firefox…) don't send that header for GET requests.

+1 from user
@avernet
Copy link
Collaborator Author

avernet commented Aug 20, 2018

As noted by Brian, a value of none seems invalid, as MIME types must have the form type/subtype, so this is definitely something we should take care of.

@avernet avernet added this to Done in Orbeon Forms 2018.1 via automation Aug 31, 2018
avernet added a commit that referenced this issue Aug 31, 2018
@avernet
Fix #3680: on Test for HTTP service, don't send none as Content-Type
2ae4fdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Module: XForms
Projects
No open projects
Orbeon Forms 2018.1
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avernet