Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for landing, forms, and admin pages to link to summary page without form version #6017

Closed
avernet opened this issue Oct 12, 2023 · 7 comments

Comments

@avernet
Copy link
Collaborator

avernet commented Oct 12, 2023

If we disable the version selector on the Form Runner summary page by setting oxf.fr.summary.show-version-selector.*.* to false, the page will show data across form versions. However, when we navigate to a summary page from the pages listed below, we have code that adds a ?form-version= parameter, and when such a parameter is present, the summary page shows only data for the specific version, even if it doesn't show the version selector.

  • The forms page (/fr/forms) or the admin page (/fr/admin), both implemented by fr/home/home.xhtml. For the relevant code in home.xhtml, search for name="link".
  • The landing page (/fr/), landing.xhtml, where we have code from the form/admin page that is duplicated (search for form-version=), first in the demo forms card, second in the published forms cards.

This RFE calls for having a configuration that can be set so that links in the forms, admin, and landing pages don't include the form-version= request parameter.

+1 from customer

@avernet
Copy link
Collaborator Author

avernet commented Oct 13, 2023

How would we configure this?

  • Two properties:
    • oxf.fr.landing.link-to-summary.include-form-version and
    • oxf.fr.home.link-to-summary.include-form-version
  • A single property: But what name to use? I don't think we have an existing property that applies to both the forms/admin and the landing pages.
  • Have the value of oxf.fr.summary.show-version-selector.*.* affect the links on these 3 pages.

@ebruchez
Copy link
Collaborator

ebruchez commented Oct 13, 2023

Note that the Admin page lists published forms by version, and would still have to pass the version number in the URL.

@avernet
Copy link
Collaborator Author

avernet commented Oct 13, 2023

Resolution: if oxf.fr.summary.show-version-selector.*.* is set to false, the forms and the landing page will not include the form-version=, but the admin page will, because it has one row per version.

@avernet avernet added this to To do in Orbeon Forms 2022.1.6 Oct 19, 2023
@avernet avernet added this to To do in Orbeon Forms 2023.1 Oct 19, 2023
@ebruchez ebruchez assigned orbeon and obruchez and unassigned orbeon Nov 29, 2023
@obruchez obruchez moved this from To do to Done in Orbeon Forms 2023.1 Nov 30, 2023
@obruchez
Copy link
Collaborator

obruchez commented Nov 30, 2023

@obruchez obruchez reopened this Nov 30, 2023
@obruchez obruchez moved this from To do to In progress in Orbeon Forms 2022.1.6 Nov 30, 2023
@obruchez obruchez moved this from In progress to Done in Orbeon Forms 2022.1.6 Nov 30, 2023
@obruchez obruchez closed this as completed Dec 1, 2023
@obruchez obruchez reopened this Dec 1, 2023
@obruchez
Copy link
Collaborator

obruchez commented Dec 1, 2023

Note: /new without form-version= will use the latest version of the form, so not including the parameter in that case is fine as well.

@obruchez
Copy link
Collaborator

obruchez commented Dec 1, 2023

Forgot to include the condition for the admin page. Now fixed.

@ebruchez
Copy link
Collaborator

Doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants