Warning about incomplete database config

[ebruchez]

Getting the following messages:

2024-01-04T08:37:22,377 ERROR relational - Data source `sqlite` not configured
2024-01-04T08:37:22,378 ERROR relational - Data source `mysql_prod` not configured
2024-01-04T08:37:22,379 ERROR XFormsServer - The following Orbeon Forms configurations are incomplete:

- The database configuration is missing or incomplete.

Curiously, in another case, I am not getting the warning about sqlite (and no warning banner). But in this case I am getting the banner.

Try to repro with different provider names locally.

[obruchez]

The Data source ... not configured error was logged even if the data source was actually configured. This is now fixed by commit 58a1c82.

The The database configuration is missing or incomplete message was/is correct, though, which means that in the case above, mysql_prod was wrongly listed as being missing, but sqlite is probably missing, isn't it?

By default, we have the following properties defined in properties-form-runner.xml:

    <property as="xs:string"  name="oxf.fr.persistence.provider.orbeon.bookshelf.form"          value="sqlite"/>
    <property as="xs:string"  name="oxf.fr.persistence.provider.orbeon.contact.form"            value="sqlite"/>
    <property as="xs:string"  name="oxf.fr.persistence.provider.orbeon.controls.form"           value="sqlite"/>
    <property as="xs:string"  name="oxf.fr.persistence.provider.orbeon.dmv-14.form"             value="sqlite"/>
    <property as="xs:string"  name="oxf.fr.persistence.provider.orbeon.w9.form"                 value="sqlite"/>
    <property as="xs:string"  name="oxf.fr.persistence.provider.orbeon.travel.form"             value="sqlite"/>

Should we consider the configuration as missing/incomplete if we have a provider correctly configured/defined for *.*.* but the demo forms are still using sqlite? If not, should we just ignore (i.e. not test) any provider defined for the demo forms, e.g. any provider defined for app = orbeon and form != builder?

I haven't been able to reproduce any problem with the banner being not displayed when it should.

[ebruchez]

So in my case:

• I do not need demo forms
• I set oxf.fr.persistence.provider.*.*.* to my own provider (not sqlite)
• but I don't set anything for the demo forms

But there is the default config for the demo forms, still pointing to sqlite.

Disabling my sqlite provider causes the banner to go away. That is sufficient for me.

• document how to disable sample forms (@ebruchez): https://doc.orbeon.com/installation#database-setup

[obruchez]

Extra logs have been added to better guide the user:

Data source `sqlite` referenced by provider `sqlite` not configured
Provider `sqlite` is used by the following properties:
 - oxf.fr.persistence.provider.orbeon.bookshelf.form
 - oxf.fr.persistence.provider.orbeon.contact.form
 - oxf.fr.persistence.provider.orbeon.controls.form
 - oxf.fr.persistence.provider.orbeon.dmv-14.form
 - oxf.fr.persistence.provider.orbeon.travel.form
 - oxf.fr.persistence.provider.orbeon.w9.form
Provider `sqlite` can be disabled by setting property `oxf.fr.persistence.sqlite.active` to `false`

[ebruchez]

Nice, that will be very helpful.

[avernet]

+1 from customer