Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When client focuses out of all fields, must dispatch DOMFocusOut #619

Closed
ebruchez opened this issue Dec 4, 2012 · 5 comments
Closed

When client focuses out of all fields, must dispatch DOMFocusOut #619

ebruchez opened this issue Dec 4, 2012 · 5 comments
Assignees
@ebruchez
Labels
4 Points Module: XForms
Milestone
4.6

Comments

@ebruchez
Copy link
Collaborator

ebruchez commented Dec 4, 2012

See #586 for an example of where this is needed.
@ghost ghost assigned avernet Dec 4, 2012
@ebruchez ebruchez mentioned this issue Dec 4, 2012
Closed
@ebruchez ebruchez mentioned this issue Jan 23, 2014
Closed
@ebruchez
Copy link
Collaborator Author

One issue caused by this bug is that validation is not triggered if the server doesn't receive the DOMFocusOut event.

@elson
Copy link

elson commented May 6, 2014

See #1503 for example of validation problem caused by this bug

@ebruchez ebruchez modified the milestones: 4.6, Review, Consider for 4.6 May 8, 2014
@ebruchez ebruchez mentioned this issue May 8, 2014
Open
@ebruchez ebruchez modified the milestones: 4.6, Consider for 4.6 May 8, 2014
@avernet
Copy link
Collaborator

avernet commented May 29, 2014

  • We want to send xforms-blur in addition to xforms-focus and xxforms-value.
  • On blur, detect if we're going to another XForms control; if we do, don't dispatch xforms-blur
    • Do this by checking if e.relatedTarget || document.activeElement is part of an XForms control.
    • We want to do this for 2 reasons:
      • Performance: since we'll later send an xforms-focus, sending the xforms-blur is superfluous.
      • Enables the server not to dispatch a DOMFocusOut when the focus goes between 2 controls within an XBL control.

avernet added a commit that referenced this issue May 31, 2014
@avernet
Unit tests for #619
605733a
avernet added a commit that referenced this issue Jun 2, 2014
@avernet
Send xforms-blur event, for #619
a99ee55
@avernet
Copy link
Collaborator

avernet commented Jun 2, 2014

  • JavaScript code now sends xxforms-blur.
  • Now server/error summary needs to use this info to show error on blur.
  • Once done, uncomment FIXME in issue619ErrorShownOnClickBody
  • Related: show error on activate (issue619ErrorShownOnActivate).
  • Related: show error for incremental (issue619Incremental).
  • Might want to create separate bugs for those, if it makes sense.
  • Re-assigning to @ebruchez.

@avernet avernet assigned ebruchez and unassigned avernet Jun 2, 2014
ebruchez added a commit that referenced this issue Jun 3, 2014
@ebruchez
For #619: server-side code
fff5274 
- rename event to xxforms-blur as it’s not standard
- allow external xxforms-blur on controls
- visitable controls
  - mark control visited
  - remove focus
- upon Ajax response, support removal of focus
- enable test
@ebruchez ebruchez closed this as completed Jun 4, 2014
This was referenced Jun 4, 2014
Open
Open
@ebruchez
Copy link
Collaborator Author

ebruchez commented Jun 4, 2014

I entered 2 separate bugs,

@ebruchez ebruchez mentioned this issue Jun 6, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebruchez ebruchez

Labels
4 Points Module: XForms
Projects
None yet
Milestone
4.6
Development

No branches or pull requests
3 participants
@elson @ebruchez @avernet