Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr:attachment: use download attribute #6198

Closed
2 tasks done
ebruchez opened this issue Feb 21, 2024 · 0 comments
Closed
2 tasks done

fr:attachment: use download attribute #6198

ebruchez opened this issue Feb 21, 2024 · 0 comments

Comments

@ebruchez
Copy link
Collaborator

ebruchez commented Feb 21, 2024

This instead of using target="_blank" ("as of 2009-05, seems to be how most sites handle this").

  • add download attribute
  • add dynamic download filename value

The filename attribute is necessary in the JavaScript environment, as there we don't proxy and so we cannot add a Content-Disposition header.

<xf:output appearance="xxf:download"> already supports a nested <xf:filename>, but that is only used for proxying. We need to make use of this to produce the dynamic filename attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant