Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module names #845

Merged
merged 12 commits into from Oct 13, 2017
Merged

Module names #845

merged 12 commits into from Oct 13, 2017

Conversation

ebocher
Copy link
Member

@ebocher ebocher commented Oct 1, 2017 •
edited

According #740, H2GIS modules have been reorganized.

  • rename the h2gis artifact id to h2gis-parent,
  • rename h2gis-functions artifact id to h2gis and h2gis-functions-osgi to h2gis-osgi
  • remove h2gis-ext and h2gis-ext-osgi
  • update the readme
  • remove h2gis-network. It must be in a separate repository.

@ebocher ebocher added this to the H2GIS 1.3.X milestone Oct 1, 2017
@nicolas-f nicolas-f self-requested a review October 2, 2017 07:46
@nicolas-f
Copy link
Member

Wut, we never talked about removing h2 network from h2gis.

I do not agree to remove h2-network and all its history from this repository. This component is widely used and is an important part of h2gis.

@nicolas-f
Copy link
Member

So I agree up to 4573a92, with an upgrade of minor version of H2GIS.

nicolas-f
nicolas-f requested changes Oct 2, 2017
View reviewed changes
Copy link
Member

@nicolas-f nicolas-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollback
57fe4c7

@ebocher
Copy link
Member Author

ebocher commented Oct 2, 2017

Ok I will roll-back for H2GIS-Network.
My fault

@nicolas-f
Copy link
Member

More easily you can checkout 4573a92 and create a new pull request

@ebocher
Copy link
Member Author

ebocher commented Oct 2, 2017 •
edited

Update to 1.4.0-SNAPSHOT

@ebocher
Copy link
Member Author

ebocher commented Oct 2, 2017

Wait before merging

@ebocher ebocher modified the milestones: H2GIS 1.3.X, H2GIS 1.4.X Oct 2, 2017
@ebocher
Copy link
Member Author

ebocher commented Oct 11, 2017

@SPalominos
Could you please have a look on this PR ?
I'm a bit busy

@SPalominos
Copy link
Contributor

OK, I on it.

@ebocher
Copy link
Member Author

ebocher commented Oct 11, 2017

Thanks a lot

@SPalominos
Copy link
Contributor

@nicolas-f Can you re-review the PR ?

@SPalominos SPalominos self-assigned this Oct 11, 2017
@nicolas-f
Copy link
Member

Have you tried the integration with OrbisGIS ? (with a safe mode)

@ebocher
Copy link
Member Author

ebocher commented Oct 12, 2017

nop

@SPalominos
Copy link
Contributor

Tested with OrbisGIS and OrbisWps, PR on those repo are comming.

@SPalominos SPalominos merged commit 18ed5fc into orbisgis:master Oct 13, 2017
@ebocher ebocher mentioned this pull request Nov 19, 2017
Closed
@ebocher ebocher deleted the moduleNames branch October 12, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-f nicolas-f nicolas-f approved these changes

Assignees

@SPalominos SPalominos

Labels
None yet
Projects
None yet
Milestone
H2GIS 2.X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebocher @nicolas-f @SPalominos