New groovy output #52

adrbessy · 2022-01-03T09:34:22Z

A Groovy Output that prints in the same way that the GroovyConsole.
There is a button allowing to delete its content.

ebocher · 2022-01-03T14:52:36Z

plugins/org.orbisgis.core/META-INF/MANIFEST.MF

@@ -19,6 +19,7 @@ Bundle-Activator: org.orbisgis.core.CoreActivator
 Bundle-ActivationPolicy: lazy
 Export-Package: org.orbisgis.core,
 org.orbisgis.core.logger,
+ org.orbisgis.core.service.definition,


to be removed ?

ebocher · 2022-01-03T14:53:20Z

.github/workflows/CI-build.yml

+          #BRANCH: p2-repository # The branch name where you want to push the assets
+          #FOLDER: ./p2/target/p2-1.0.0-SNAPSHOT # The directory where your assets are generated
+          #GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # GitHub will automatically add this - you don't need to bother getting a token
+          #MESSAGE: "Build: plugins available from p2-repository" # The commit message


The p2-1.0.0-SNAPSHOT cannot be pushed to p2-repository,
There is this message:
remote: Permission to orbisgis/orbisrcp.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/orbisgis/orbisrcp.git/': The requested URL returned error: 403

@SPalominos could you check when you will have the time ;-)

Is the GITHUB_TOKEN already active ?

ebocher · 2022-01-03T14:53:56Z

plugins/org.orbisgis.core/src/org/orbisgis/core/ui/ToolbarButton.java

@@ -97,7 +105,7 @@ public void mouseHover(MouseEvent e) {

        this.addMouseListener(new MouseAdapter() {
            @Override
-            public void mouseDown(MouseEvent e) {
+            public void mouseDown(MouseEvent e) {            	


remove blank space.
You can used format with the ide

ebocher · 2022-01-03T14:54:18Z

plugins/org.orbisgis.groovyeditor/META-INF/MANIFEST.MF

@@ -21,4 +21,6 @@ Require-Bundle: org.eclipse.core.runtime,
 dependencies
 Bundle-ActivationPolicy: lazy
 Bundle-Activator: org.orbisgis.ui.editors.groovy.GroovyActivator
-
+Import-Package: org.jkiss.dbeaver.core,
+ org.jkiss.dbeaver.ext.sample.database,


necessary ?

ebocher · 2022-01-03T14:54:52Z

plugins/org.orbisgis.groovyeditor/plugin.xml

@@ -41,21 +54,40 @@
            description="Clear the script"
            id="org.orbisgis.ui.editors.groovy.clear"
            name="Clear script"> </command>
+<!--
+      <command


ebocher · 2022-01-03T14:56:33Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/browser/OpenHandler.java

+import org.orbisgis.ui.editors.groovy.GroovyEditor;
+import org.orbisgis.ui.editors.groovy.GroovyUtils;
+
+public class OpenHandler extends AbstractHandler {


Add author
Adrien Bessy, LAB-STICC, CNRS

This class is never used ?

This class allows to open a web page in the software, but we don't use it.

ebocher · 2022-01-03T14:57:51Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/editors/groovy/GroovyConsoleView.java

+
+	private void createDeleteOutputButton(Composite group) {
+		final MenuManager menuMgr = new MenuManager();
+		menuMgr.setRemoveAllWhenShown(true);


Format the code with the IDE

ebocher · 2022-01-03T14:58:22Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/editors/groovy/GroovyEditor.java

@@ -140,4 +145,18 @@ public void stop(){
    public GroovyJob getRunningJob() {
        return job;
    }
+
+	public void changeGroovyInterpreter() {


Never used ?

ebocher · 2022-01-03T14:58:35Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/editors/groovy/GroovyEditor.java

+			LOGGER.info("GroovyScriptEngine is now selected.");
+		} else {
+			this.groovyInterpreter = "GroovyShell";
+			System.out.println("\n***\n groovyInterpreter in changeGroovyInterpreter method : " + groovyInterpreter + "\n***\n");


remove println

ebocher · 2022-01-03T14:59:10Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/editors/groovy/GroovyJob.java

        super(name);
        this.script = script;
        this.name = name;
-
+		System.out.println("\n***\n in GroovyJob constructor \n***\n");


Don't used any println in the code, use log system if necessary

ebocher · 2022-01-03T16:16:39Z

.github/workflows/CI-build.yml

+          #BRANCH: p2-repository # The branch name where you want to push the assets
+          #FOLDER: ./p2/target/p2-1.0.0-SNAPSHOT # The directory where your assets are generated
+          #GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # GitHub will automatically add this - you don't need to bother getting a token
+          #MESSAGE: "Build: plugins available from p2-repository" # The commit message


@SPalominos could you check when you will have the time ;-)

ebocher · 2022-01-03T16:17:23Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/editors/groovy/GroovyJob.java

                }
+                Object res3 = shell.getProperty("out");


Format code

ebocher · 2022-01-04T08:15:57Z

.github/workflows/CI-build.yml

+          #BRANCH: p2-repository # The branch name where you want to push the assets
+          #FOLDER: ./p2/target/p2-1.0.0-SNAPSHOT # The directory where your assets are generated
+          #GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # GitHub will automatically add this - you don't need to bother getting a token
+          #MESSAGE: "Build: plugins available from p2-repository" # The commit message


Is the GITHUB_TOKEN already active ?

ebocher · 2022-01-04T08:16:26Z

plugins/org.orbisgis.groovyeditor/META-INF/MANIFEST.MF

@@ -21,4 +21,4 @@ Require-Bundle: org.eclipse.core.runtime,
 dependencies
 Bundle-ActivationPolicy: lazy
 Bundle-Activator: org.orbisgis.ui.editors.groovy.GroovyActivator
-
+Import-Package: org.jkiss.dbeaver.registry.driver


ebocher · 2022-01-04T08:20:07Z

plugins/org.orbisgis.groovyeditor/src/org/orbisgis/ui/editors/groovy/GroovyJob.java


-    public GroovyJob(String name, String script){
+    public GroovyJob(String name, String script, String groovyInterpreter){


I don't understand why you set a String argument to define the groovy engine.
I think you can remove it and use the original code. No ?

adrbessy added 23 commits November 30, 2021 09:24

start to add the demat plugin

a282265

the demat plugin can be installed

8b31097

Change CharExtension class

3d346d0

cancel plugins parent in the pom

5891302

Fix the groovy file name and package

fd634ce

Open method can be called

9fefea7

Last modif

cfaf972

Ongoing Work on GroovyShell process

5fa6267

Creation of an osgi groovyGrabService ongoing

213e631

GroovyGrab service works

565ad34

Create a button to choose the groovy interpreter

93401c0

create groovy output view

b54eba7

new groovy output (console)

8a14bff

button to clear groovy output

55cb9eb

Clear button for groovy output isin a menu

3342761

groovy output is colored

850911f

print the standard output in the Groovy Output

f701012

Still doesn't work

4fcb4f6

GroovyOutput PR

25dbd34

GroovyOutput PR cleaned

baca18c

GroovyOutput PR cleaned 2nd time

3fdb2e5

GroovyOutput PR cleaned 3rd time

45068c4

GroovyOutput PR cleaned 4th time

0a02c79

ebocher reviewed Jan 3, 2022

View reviewed changes

adrbessy added 2 commits January 3, 2022 16:11

Delete unuseful code

08525f2

delete unuseful code lines

f910bf7

adrbessy force-pushed the new-groovyOutput branch from 016514c to f910bf7 Compare January 3, 2022 15:53

ebocher reviewed Jan 3, 2022

View reviewed changes

Format code of shell getProperty

60761f5

ebocher reviewed Jan 4, 2022

View reviewed changes

adrbessy force-pushed the new-groovyOutput branch from fb6eeae to 60761f5 Compare January 4, 2022 08:26

adrbessy closed this Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New groovy output #52

New groovy output #52

adrbessy commented Jan 3, 2022

ebocher Jan 3, 2022

adrbessy Jan 3, 2022

ebocher Jan 3, 2022

adrbessy Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 4, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

adrbessy Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

adrbessy Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 3, 2022

ebocher Jan 4, 2022

ebocher Jan 4, 2022

ebocher Jan 4, 2022 •

edited

Loading


		public GroovyJob(String name, String script){
		public GroovyJob(String name, String script, String groovyInterpreter){

New groovy output #52

New groovy output #52

Conversation

adrbessy commented Jan 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ebocher Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

ebocher Jan 4, 2022 •

edited

Loading