Reduce object allocation with MessageSerializer. #293

johnou · 2018-04-03T10:15:21Z

No pooling

Benchmark                                         Mode  Cnt       Score      Error  Units
SingleNodeBenchmark.requestThroughput            thrpt   40  163676.503 ± 1647.612  ops/s
SingleNodeBenchmark.avgRequestTime_batched        avgt   40       3.958 ±    0.086  us/op
SingleNodeBenchmark.avgRequestTime_singleThread   avgt   40      20.065 ±    0.745  us/op

Pooling

Benchmark                                         Mode  Cnt       Score      Error  Units
SingleNodeBenchmark.requestThroughput            thrpt   40  170217.244 ± 1900.282  ops/s
SingleNodeBenchmark.avgRequestTime_batched        avgt   40       3.808 ±    0.053  us/op
SingleNodeBenchmark.avgRequestTime_singleThread   avgt   40      19.840 ±    1.029  us/op

Fixes #292

johnou · 2018-04-03T13:39:04Z

actors/runtime/src/main/java/cloud/orbit/actors/runtime/KryoSerializer.java

-                return null;
-            }
-        });
+                return out.toBytes();


no risk of data corruption here, new byte array is returned, not the pooled byte array.

* upstream/master: (32 commits) Mainline to 1.9.3-SNAPSHOT Version 1.9.2 Fix invalid use of await in Hosting.shouldPlaceLocally() (orbit#297) Mainline to 1.9.2-SNAPSHOT Version 1.9.1 Guard against output buffer overflow. (orbit#296) Mainline to 1.9.1-SNAPSHOT Version 1.9.0 Add node placement group support (orbit#295) Guard against input buffer underflow. (orbit#294) Update orbit-parent to 2 Reduce object allocation with MessageSerializer. (orbit#293) JDK9+ Support Update README.md Avoid creating Task every time done() is invoked. (orbit#291) Mainline to 1.8.1-SNAPSHOT Version 1.8.0 JVM Shutdown Hook (orbit#290) Optimise object allocation when using allOf with Streams. (orbit#289) fast-classpath-scanner 2.9.4. (orbit#288) ... # Conflicts: # actors/core/pom.xml # actors/infinispan-cluster/pom.xml # actors/json/pom.xml # actors/pom.xml # actors/runtime/pom.xml # actors/runtime/src/main/java/cloud/orbit/actors/Stage.java # actors/runtime/src/main/java/cloud/orbit/actors/runtime/KryoSerializer.java # actors/test/actor-tests/pom.xml # actors/test/benchmarks/pom.xml # commons/pom.xml # commons/src/main/java/cloud/orbit/concurrent/Task.java # pom.xml

johnou added 3 commits April 3, 2018 12:13

Return byte array from MessageSerializer.

d0a44f0

Pool Kryo Input and Output objects.

bc9f363

Fix caching.

d8261fd

johnou changed the title ~~WIP: Reduce object allocation with MessageSerializer.~~ Reduce object allocation with MessageSerializer. Apr 3, 2018

johnou commented Apr 3, 2018

View reviewed changes

johnou added 3 commits April 3, 2018 21:00

Use base class.

05d66f9

Simplify deserialize.

2c79fdb

Add test.

d4d4428

JoeHegarty merged commit 55a4a5d into orbit:master Apr 3, 2018

johnou deleted the improved_serialization branch April 3, 2018 21:37

JoeHegarty added this to the 1.9.0 milestone May 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce object allocation with MessageSerializer. #293

Reduce object allocation with MessageSerializer. #293

johnou commented Apr 3, 2018 •

edited

johnou Apr 3, 2018

Reduce object allocation with MessageSerializer. #293

Reduce object allocation with MessageSerializer. #293

Conversation

johnou commented Apr 3, 2018 • edited

johnou Apr 3, 2018

Choose a reason for hiding this comment

johnou commented Apr 3, 2018 •

edited