This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
feat: add the optional argument cache to the constructor
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamb0t
reviewed
Oct 29, 2019
| constructor (input = {}) { | ||
| if (typeof input === 'string') { | ||
| this._store = createStore(input) | ||
| } else if (typeof input.open === 'function') { |
There was a problem hiding this comment.
Can you explain the purpose of checking input.open? Are you treating the options object as the store? Imo we should expect the store to be passed as options.store
There was a problem hiding this comment.
Hi @shamb0t,
From my understanding, the current API allows three cases:
- no arguments
- a string which must be a path
- a
levelstore
So yes the first if block checks if input is a level store (case .3).
And the second one checks if input is a string, i.e. a path (case .2).
The intend is to avoid breaking changes.
However, if breaking changes are OK on your side I can review the constructor implementation accordingly.
Best regards
|
@shamb0t no problems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
The pull request related to #41.
Best regards