Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Adding a directories list #3

Merged
merged 3 commits into from Jul 25, 2018
Merged

Adding a directories list #3

merged 3 commits into from Jul 25, 2018

Conversation

RichardLitt
Copy link
Contributor

@RichardLitt RichardLitt commented Jun 8, 2018

This is a basic directories list. For the README, it should give an entry into the org more than the basic list used currently on the @orbitdb page.

@RichardLitt RichardLitt changed the title [WIP] Adding a directories list Adding a directories list Jul 9, 2018
@RichardLitt RichardLitt requested a review from a team July 9, 2018 17:50

- [orbit-db-store](https://github.com/orbitdb/orbit-db-store)

This is a base calls for all datastores in orbitdb. A Base Class defines the common interface for all databases. We should refactor this - it should not be a base class, but a composting (?). We'll figure this out. The Stores are the API of that database; they also contian the index so that if you cac he anything in the memory, the user never actually directly asks the index, but the API of the store. All of these stores use -- they're very simple, there's no io or so on. The store is where that happens. Every store calls this operation which calls the log, and so on, and eventually sends a cb somewhere saying that it is persisted. It has a load method that checks the cache, then ... I lost it. The base class hooks the orbitdb main thing, that contains the messaging and the keystore and the access-controller with the log and the form and so on with the indices.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/calls/class
s/contian/contain
s/cac he/cache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was for an older commit? :)

@rjharmon
Copy link

whoops, sorry :)

@RichardLitt
Copy link
Contributor Author

This is better than what we have. Errors or not, I am going to merge it now. If anyone has suggestions, feel free to open a new PR for them!

@RichardLitt RichardLitt merged commit ab7f5ca into master Jul 25, 2018
@RichardLitt RichardLitt deleted the feat/ls-dir branch July 25, 2018 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants