Update 01_Basics.md #146
Open
Update 01_Basics.md #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update outdated name of pubsub option
CSDUMMI
approved these changes
Sep 14, 2021
|
|
|
Yes. See the CHANGELOG.md 0.38.0-rc.0. I think that in this case the entire thing should be removed. |
CSDUMMI
suggested changes
Sep 15, 2021
| @@ -120,7 +120,7 @@ class NewPiecePlease { | |||
| this.node = await this.Ipfs.create({ | |||
| preload: { enabled: false }, | |||
| repo: './ipfs', | |||
| EXPERIMENTAL: { pubsub: true }, | |||
| EXPERIMENTAL: { ipnsPubsub: true }, | |||
There was a problem hiding this comment.
I suggest removing this line, if pubsub is now enabled by default.
| @@ -165,7 +165,7 @@ for now, we include this line to disable them. | |||
| - `repo: './ipfs'` designates the path of the repo in Node.js only. In the browser, you can actually remove this line. The | |||
| default setting is a folder called `.jsipfs` in your home directory. You will see why we choose this specific location for the | |||
| folder later. | |||
| - `EXPERIMENTAL: { pubsub: true }` enables [IPFS pubsub](https://blog.ipfs.io/25-pubsub/), which is a method of communicating between nodes and **is required for OrbitDB usage**, despite whether or not we are connected to other peers. | |||
| - `EXPERIMENTAL: { ipnsPubsub: true }` enables [IPFS pubsub](https://blog.ipfs.io/25-pubsub/), which is a method of communicating between nodes and **is required for OrbitDB usage**, despite whether or not we are connected to other peers. | |||
There was a problem hiding this comment.
Perhaps this could be removed and a note added somewhere else, about how OrbitDB uses PubSub.
(Maybe in the Introduction).
|
Is the |
I'm going to assume so because swarm peers is disabled if in offline mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update outdated name of pubsub option