Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Let the AC decide if it wants to skip using a manifest. #33

Merged
merged 3 commits into from May 17, 2019

Conversation

@oed
Copy link
Contributor

oed commented May 17, 2019

This let's access controllers decide if they should skip the manifest creation. Using this new access controllers that are backwards compatible can be created.

@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented May 17, 2019

Thanks @oed! The issue with skipping a manifest is that AccessController.resolve will not be able to know which ac-type to load. So if the skipManifest options is set to true, we should throw an error if the type is not passed in the options.

shamb0t and others added 2 commits May 17, 2019
feat: skip ac-manifest
@shamb0t

This comment has been minimized.

Copy link
Member

shamb0t commented May 17, 2019

Thanks @oed! Lgtm 👍

@shamb0t shamb0t merged commit 7e24bc1 into orbitdb:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.