This repository has been archived by the owner on Sep 30, 2023. It is now read-only.
feat: Let the AC decide if it wants to skip using a manifest. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @oed! The issue with skipping a manifest is that AccessController.resolve will not be able to know which ac-type to load. So if the skipManifest options is set to true, we should throw an error if the |
feat: skip ac-manifest
|
Thanks @oed! Lgtm 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This let's access controllers decide if they should skip the manifest creation. Using this new access controllers that are backwards compatible can be created.