Upgrade to js-IPFS v0.38.x-rc #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphelionz
reviewed
Sep 27, 2019
|
@achingbrain Also it looks like while tests are passing, there's a number of socket resets and disconnects after the tests pass. I believe this is on our end but any feedback / guidance you have there is obviously beneficial.
|
There's a new release of js-IPFS around the corner, one of the things it does is turn on pubsub by default so needs a little code tweaking to work. This PR contains the changes required to get orbit-db working with the latest release candidate.
achingbrain
force-pushed
the
upgrade-to-js-ipfs-0.38.x-rc
branch
from
05203be
to
52b1aa3
Compare
|
@aphelionz my experience of those sorts of socket resets is that they are requests to the daemon that are in-flight while it's being shut down, usually in an |
|
Merged to develop! Thanks @achingbrain. We'll be able to look at those socket issues in |
|
Great stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a new release of js-IPFS around the corner, one of the things it does is turn on pubsub by default so needs a little code tweaking to work.
This PR contains the changes required to get orbit-db working with the latest release candidate.